django-cms / djangocms-frontend

django CMS frontend is a plugin bundle for django CMS providing several components for the frontend, currently implemented with the popular Bootstrap 5 framework.
Other
48 stars 21 forks source link

fix: Link template choices from correct setting #98

Closed bielfrontera closed 1 year ago

bielfrontera commented 1 year ago

Template choices in LinkForm were being computed from the setting DJANGOCMS_LINK_TEMPLATES instead of LINK_TEMPLATE_CHOICES, that is the setting that exists on djangocms_frontend.settings

codecov[bot] commented 1 year ago

Codecov Report

Merging #98 (7caddb5) into master (e50fb61) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   86.34%   86.32%   -0.02%     
==========================================
  Files         110      110              
  Lines        2974     2970       -4     
  Branches      321      321              
==========================================
- Hits         2568     2564       -4     
  Misses        309      309              
  Partials       97       97              
Impacted Files Coverage Δ
djangocms_frontend/contrib/link/forms.py 82.26% <ø> (-0.49%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fsbraun commented 1 year ago

@bielfrontera Well spotted! Can you add a changelog entry? Thank you!

bielfrontera commented 1 year ago

@fsbraun: done. Changelog modified!

fsbraun commented 1 year ago

... and migrations updated! Thanks!