search

django-cms / djangocms-history

Provides undo/redo functionality for django CMS operations
https://www.django-cms.org
Other
28 stars 13 forks source link

Compatibility with Django CMS 3.6 #30

Closed joeljv91 closed 3 years ago

joeljv91 commented 5 years ago

It's compatible with this version?

I installed the latest Django CMS 3.6 version and after execute a migration this error appear on console:

Traceback (most recent call last): File "manage.py", line 24, in execute_from_command_line(sys.argv) File "/var/www/venv/lib/python3.5/site-packages/django/core/management/init.py", line 364, in execute_from_command_line utility.execute() File "/var/www/venv/lib/python3.5/site-packages/django/core/management/init.py", line 338, in execute django.setup() File "/var/www/venv/lib/python3.5/site-packages/django/init.py", line 27, in setup apps.populate(settings.INSTALLED_APPS) File "/var/www/venv/lib/python3.5/site-packages/django/apps/registry.py", line 108, in populate app_config.import_models() File "/var/www/venv/lib/python3.5/site-packages/django/apps/config.py", line 202, in import_models self.models_module = import_module(models_module_name) File "/usr/lib/python3.5/importlib/init.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "", line 986, in _gcd_import File "", line 969, in _find_and_load File "", line 958, in _find_and_load_unlocked File "", line 673, in _load_unlocked File "", line 673, in exec_module File "", line 222, in _call_with_frames_removed File "/var/www/venv/lib/python3.5/site-packages/djangocms_history/models.py", line 25, in from . import action_handlers File "/var/www/venv/lib/python3.5/site-packages/djangocms_history/action_handlers.py", line 4, in from .helpers import delete_plugins, disable_cms_plugin_signals File "/var/www/venv/lib/python3.5/site-packages/djangocms_history/helpers.py", line 11, in from cms.signals import ( ImportError: cannot import name 'pre_delete_plugins'

Any ideas?

Thanks

joeljv91 commented 5 years ago

Ok on Django CMS 3.6 they remove this signals.

https://github.com/divio/django-cms/commit/99880979884de94b1f2784bb830ad5cf6d7bdea7#diff-643105bbf8c6920853343a09e34d38ac

So for the moment it's not compatible. It's a little bit confusing the requirements compatibility on the doc page "Django 3.4+"

FinalAngel commented 5 years ago

@joeljv91 the tests for 3.4, 3.5 and 3.6 pass plus we use it on several instances by now. What version where you using (of djangocms-history)?