search

django-cms / djangocms-history

Provides undo/redo functionality for django CMS operations
https://www.django-cms.org
Other
28 stars 13 forks source link

BUG: Cannot undo/redo plugin djangocms-picture. #52

Closed svandeneertwegh closed 9 months ago

svandeneertwegh commented 10 months ago

I added a image in my structure plugins.

When i click undo/redo i get the following error:

File "/Users/stefan/projects/djcms3/djangocms_history/models.py", line 395, in _object_version_data_hook return ArchivedPlugin(**data) TypeError: <lambda>() got an unexpected keyword argument 'model'

fsbraun commented 10 months ago

Do you have a traceback?

svandeneertwegh commented 10 months ago

Yes. Here https://elmah.io/tools/stack-trace-formatter/5c706a8685c0439d93f5e045327d3d8c/

@fsbraun adds: For direct access:

Internal Server Error: /admin/djangocms_history/placeholderoperation/undo/
Traceback (most recent call last):
  File "/Users/stefan/projects/corebyte-companysite/venv/lib/python3.9/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/Users/stefan/projects/corebyte-companysite/venv/lib/python3.9/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/Users/stefan/projects/corebyte-companysite/venv/lib/python3.9/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
  File "/Users/stefan/projects/corebyte-companysite/venv/lib/python3.9/site-packages/django/views/generic/base.py", line 143, in dispatch
    return handler(request, *args, **kwargs)
  File "/Users/stefan/projects/corebyte-companysite/djangocms_history/views.py", line 35, in post
    self.object.undo()
  File "/usr/local/Cellar/python@3.9/3.9.18/Frameworks/Python.framework/Versions/3.9/lib/python3.9/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/Users/stefan/projects/corebyte-companysite/djangocms_history/models.py", line 340, in undo
    action.undo()
  File "/usr/local/Cellar/python@3.9/3.9.18/Frameworks/Python.framework/Versions/3.9/lib/python3.9/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/Users/stefan/projects/corebyte-companysite/djangocms_history/models.py", line 413, in undo
    _action_handlers[self.action]['undo'](self)
  File "/Users/stefan/projects/corebyte-companysite/djangocms_history/action_handlers.py", line 82, in undo_add_plugin
    post_data = action.get_post_action_data()
  File "/Users/stefan/projects/corebyte-companysite/djangocms_history/models.py", line 409, in get_post_action_data
    return self._get_parsed_data(self.post_action_data)
  File "/Users/stefan/projects/corebyte-companysite/djangocms_history/models.py", line 399, in _get_parsed_data
    data = json.loads(
  File "/usr/local/Cellar/python@3.9/3.9.18/Frameworks/Python.framework/Versions/3.9/lib/python3.9/json/__init__.py", line 359, in loads
    return cls(**kw).decode(s)
  File "/usr/local/Cellar/python@3.9/3.9.18/Frameworks/Python.framework/Versions/3.9/lib/python3.9/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/Cellar/python@3.9/3.9.18/Frameworks/Python.framework/Versions/3.9/lib/python3.9/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
  File "/Users/stefan/projects/corebyte-companysite/djangocms_history/models.py", line 395, in _object_version_data_hook
    return ArchivedPlugin(**data)
TypeError: <lambda>() got an unexpected keyword argument 'model'
[07/Sep/2023 21:09:57] "POST /admin/djangocms_history/placeholderoperation/undo/ HTTP/1.1" 500 163437