django-cms / djangocms-history

Provides undo/redo functionality for django CMS operations
https://www.django-cms.org
Other
28 stars 13 forks source link

fix: Allow undo/redo for plugins that use django-entangled reference conventions #53

Closed fsbraun closed 9 months ago

fsbraun commented 10 months ago

Description

Improve detection of ArchivedPlugin data to prevent confusion with other serialized data that contains pk as a keyword, such as references managed by django-entangled.

ArchivedPlugin needs at least three properties: pk, plugin_type and position.

This PR also bumps the version and changelog.

Related resources

Checklist

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (2195205) 33.24% compared to head (5fbd4f4) 33.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #53 +/- ## ======================================= Coverage 33.24% 33.24% ======================================= Files 17 17 Lines 728 728 Branches 71 71 ======================================= Hits 242 242 Misses 485 485 Partials 1 1 ``` | [Files Changed](https://app.codecov.io/gh/django-cms/djangocms-history/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms) | Coverage Δ | | |---|---|---| | [djangocms\_history/models.py](https://app.codecov.io/gh/django-cms/djangocms-history/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX2hpc3RvcnkvbW9kZWxzLnB5) | `45.63% <0.00%> (ø)` | | | [djangocms\_history/\_\_init\_\_.py](https://app.codecov.io/gh/django-cms/djangocms-history/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX2hpc3RvcnkvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.