search

django-cms / djangocms-moderation

Other
13 stars 20 forks source link

The version admin contains a link to unpublish #165

Open jonathan-s opened 4 years ago

jonathan-s commented 4 years ago

When a model is moderated any unpublishing should also be moderated. Right now the versioning admin contains a link to unpublish content. Ideally this should be removed when a model is moderated.

When cms_config is run we could potentially register a modified variant of VersionAdmin that doesn't contain the unpublishing link. A potential issue is the order in which the various cms_config is run. Depending on whether cms_config for versioning runs first the version admin might already be registered.

https://github.com/divio/djangocms-versioning/blob/master/djangocms_versioning/helpers.py#L79-L87

fsbraun commented 1 year ago

Would an alternative be to show VersionAdmin actions according to the check_unpublish (or all the other check_... properties)?