search

django-cms / djangocms-moderation

Other
13 stars 20 forks source link

fix: Refactor flawed add to collection XSS redirect sanitisation added in 1.0.26 #199

Closed Aiky30 closed 2 years ago

Aiky30 commented 2 years ago

An issue has been recorded where the added to collection redirect view incorrectly redirects from djangocms-moderation version 1.0.26+

The redirect is broken in 1.0.26 because a security fix was implemented to prevent reflected XSS attacks hence the need for sanitisation.

codecov-commenter commented 2 years ago

Codecov Report

Merging #199 (601678d) into master (70a7837) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   84.11%   84.12%           
=======================================
  Files          23       23           
  Lines        1731     1732    +1     
  Branches      280      280           
=======================================
+ Hits         1456     1457    +1     
  Misses        245      245           
  Partials       30       30
Impacted Files Coverage Δ
djangocms_moderation/views.py 90.90% <100.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70a7837...601678d. Read the comment docs.