search

django-cms / djangocms-moderation

Other
13 stars 20 forks source link

fix: Broken markup and js scripts in the ModerationRequest changelist view #224

Closed Aiky30 closed 1 year ago

Aiky30 commented 1 year ago

The cms styles and mark up were injected into the body tag, this had a knock on effect with loaded js too where the globals from django were not added from the i18n.js file among other things.

Screenshot 2022-07-08 at 11 42 44

codecov[bot] commented 1 year ago

Codecov Report

Merging #224 (09e497f) into master (fbe7a6a) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files          23       23           
  Lines        1740     1740           
  Branches      282      282           
=======================================
  Hits         1465     1465           
  Misses        245      245           
  Partials       30       30
Impacted Files Coverage Δ
djangocms_moderation/admin.py 78.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fbe7a6a...09e497f. Read the comment docs.