Closed adam-murray closed 1 year ago
Merging #229 (1dc146e) into master (597316b) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #229 +/- ##
=======================================
Coverage 84.19% 84.19%
=======================================
Files 23 23
Lines 1740 1740
Branches 282 282
=======================================
Hits 1465 1465
Misses 245 245
Partials 30 30
Impacted Files | Coverage Δ | |
---|---|---|
djangocms_moderation/models.py | 93.23% <ø> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This pull request introduces 2 alerts when merging 375586c472487b6eea20265694fcda81d8e2d4fa into 597316bd9d931221a757b0eb0c5200ebdb41b77c - view on LGTM.com
new alerts:
@Aiky30
Hi Andrew, Can you please help to review the PR?
@Aiky30 Hi Andrew, Can you please help to review the PR?
Hi Josh, Sure, I can review this as a member of the community.
Language max length assumes all language code will be 5 or less characters, this does not apply to some east Asian language codes, which require a higher limit.
As the language field uses choices, and these are configured in settings, I have increased the max_length 25 to include some wiggle room for future language code updates.