search

django-cms / djangocms-moderation

Other
13 stars 21 forks source link

Treebeard_css templatetag missing #240

Closed joshyu closed 1 year ago

joshyu commented 1 year ago

Djangocms depends on django-treebeard but don’t lock down the version. The django-treebeard removed treebeard_css templatetag since version 4.6, but in moderation we still have an overridden template which use this tag.

Can you guys please help to fix it?

Sent with GitHawk

joshyu commented 1 year ago

@Aiky30

adam-murray commented 1 year ago

Hi Josh, I think it would be best to pin your django-treebeard version in your project. The logic behind not pinning this in the package itself is that we don't want to be forcing users to be on a given version of a dependency, so it'll mean you have more freedom to do with the app as you please.

joshyu commented 1 year ago

Hi @adam-murray ， I don't think so. As latest django-treebeard removed treebeard_css tag, most django-cms projects which is based on CMS4 will have this issue and the developers don't realize that they need to lock down django-treebeard version.

Meanwhile, this treebeard_css only include treebeard/treebeard-admin.css (see here), we can follow what is updated in django-treebeard template to remove the use of treebeard_css tag (see here).

marksweb commented 1 year ago

@joshyu pinning the version of treebeard became problematic.

I think there's a good chance that you won't find many other users of moderation at the moment. Sounds fair that we pin treebeard from moderation based on what you've said. If you're able to submit a PR, we can get it merged. Otherwise we will try to get this looked at.

marksweb commented 1 year ago

This should be resolved by #241