feat: Django 4.2 support

django-cms / djangocms-moderation

Other

13 stars 20 forks source link

feat: Django 4.2 support #256

Closed Aiky30 closed 3 months ago

Aiky30 commented 3 months ago

What does this PR do?

Adds python 3.10, 3.11 and 3.12 support
Removes djangocms-version-locking as a dependancy, becasue it's not a DCA supported package
Removes aldryn-forms, because it's deprecated and the featureset is not actually used anywhere as far as I am aware.
Removes python 3.7 and 3.8 support

Remaining issues to fix:

Monkey patching on versioning states (should be a plan to move away from these in the near future by designing versioning to be overridden properly)
Confirmation page can add a "form", this form was supposed to be a form builder. It was never used, but the ability to add plain confirmation pages, or templates is still possible so only a minor degradation.
Check with Josh if any entries are present for "Confirmation Pages" to be sure that no one is using the confirmation page form builder. If not, destruct it completely.

wfehr commented 3 months ago

I tried installing djangocms-moderation with this fork but the migrations fail for an initial setup of the database. I don't know if it's a problem with this fork (i.e. with this changes mysql 8 is possible) or a general error also occuring with mysql 5 (= django 4.1):

ValueError: The database backend does not accept 0 as a value for AutoField.

This occurs from migration djangocms_moderation.0003_auto_20180903_1206 which provided a one-off-default for a ForeignKey with the value 0.

wfehr commented 3 months ago

I tried installing djangocms-moderation with this fork but the migrations fail for an initial setup of the database. I don't know if it's a problem with this fork (i.e. with this changes mysql 8 is possible) or a general error also occuring with mysql 5 (= django 4.1):

ValueError: The database backend does not accept 0 as a value for AutoField.

This occurs from migration djangocms_moderation.0003_auto_20180903_1206 which provided a one-off-default for a ForeignKey with the value 0.

Just tried it with installing django = 4.1 - same error. I'll create a new issue für this.

Aiky30 commented 3 months ago

This change has been superseded by: https://github.com/django-cms/djangocms-moderation/pull/262