django-cms / djangocms-moderation

Other
13 stars 21 forks source link

ModerationCollection and generic ModerationRequest (1.0.x) #32

Closed mmoravcik closed 6 years ago

mmoravcik commented 6 years ago

This PR should cover FIL-330 (Create Collection model) and FIL-129 (Make moderation generic) and is a groundwork for the new Moderation development

The goal was to:

Create a new collection model and move the Workflow from ModerationRequest there Rename all Page models to , e.g. PageModerationRequest will become ModerationRequest Remove all 3.5 related code or a good chunk of it (more to come) Things to consider

Current master is 3.5 version and is already released. It is tightly coupled to a Page model. Going forward, we've created release/1.0.x branch, which we should use going forward with moderation. This means that we can start 'from scratch', e.g. create a new initial migration, otherwise renaming all the models would be a pain - sounds good? Few tests are failing and should be solved by FIL-335, which will be branched off this branch. The reason is that workflow has no more connection to ModerationRequest. We move those methods to Collection in FIL-335 UPDATE: As discussed with Paulo, we need to discuss the upgrade strategy for the current FIL sites using moderation. The ideal outcome is that release/1.0.x branch will become a new master when MVP is released