Closed greyhare closed 1 year ago
Patch: force_str.patch
Applied with patch -p1 < force_str.patch
in the module directory. Works for me.
@greyhare Thank you for the patch! Can I interest you in creating a pull request?
What else do I need in the pull request?
E.g. change log, version bump, tests, other checks...
Extending the tests to current Django/Django CMS versions would be great!
OK, this got weirder. This issue is fixed in commit 342c221 from last year. A chore for bumping version to 2.0.0.
Why is 1.0.0 the latest thing on PyPI?! That's what I'm getting:
$ ./venv/bin/pip index versions djangocms-modules
WARNING: pip index is currently an experimental command. It may be removed/changed in a future release without prior warning.
djangocms-modules (1.0.0)
Available versions: 1.0.0, 0.3.0, 0.2.0, 0.1.0
INSTALLED: 1.0.0
LATEST: 1.0.0
Hm. It seems like the 2.0.0
version was never actually released? (@marksweb : Do you remember why?).
So this might be the great point in time for djangocms-modules 2.0.0!
Things to update are:
CHANGELOG.rst
djangocms-modules/__init__.py
(since 2.0.0 is not out, no change needed)dj41_cms311.py
and dj42_cms311.py
to be added in tests/requirements/
tox.ini
to reflect the changes in test requirements and cases.github/workflows/test.yml
to be in sync with tox.ini
No idea what to change in CHANGELOG.rst
. Everything else was straightforward and passed tox
so I pushed.
@fsbraun @greyhare so looks like I did a few update bits for v2 and don't didn't finish releasing it? I imagine wife/kids/life distracted me and I forgot that I'd not released it. 🤦♂️
OK, so what's left to do?
I gues: Release it! 🎉. Thanks, @greyhare !
In
django.utils.encoding
,force_text
was deprecated in Django 3.0. It was replaced withforce_str
in Django 2.0.I get this error when using this package with Django 4.2:
It looks like this is only used in two files:
cms_plugins.py
cms_toolbars.py