search

django-cms / djangocms-modules

Create plugins right from your content.
https://www.django-cms.org
Other
15 stars 8 forks source link

Permission Based Structure Changes in Modules #5

Closed SteinRobert closed 5 years ago

SteinRobert commented 6 years ago

We'd like to extend the modules extension in the following way:

  1. Implement a typical django permission which defines whether a user is allowed to change the structure of a module.
  2. If a user is not allowed to change the structure of a module, we remove the css classes which make a plugin collapsible in the structure view e.g.: .cms-dragitem-collapsable. We might need a template tag to check the permission here.

This would make it possible for admin, superusers or sitebuilders to define well structured modules without allowing any other editor of the CMS to break out of the given structures. The editors are just allowed to change the content via double click and dragging the whole module to another place within the placeholder.

It would be nice if we could get some feedback on this @FinalAngel @czpython

Do you think this is a suitable way to implement the asked requirements?

FinalAngel commented 6 years ago

@SteinRobert generally I'm for it however I'd need to redirect the technical questions / details to @czpython. @czpython might need some time to answer as he's partially available this week.

czpython commented 6 years ago

Hello @SteinRobert, Thanks for your patience on this. I think your proposal is good, my only concern is point 2 because there might be some side-effects. Would like to get @vxsx's feedback on that.

vxsx commented 5 years ago

Sounds good. Although I think keyboard shortcuts might still allow expanding / collapsing, but i'm not sure anymore.

FinalAngel commented 5 years ago

@SteinRobert are there still plans to add these changes from your end? Otherwise I'll close this for now :)

SteinRobert commented 5 years ago

Nope, we can close this.