django-cms / djangocms-snippet

django CMS Snippet provides a plugin for django CMS to inject HTML, CSS or JavaScript snippets into your website.
https://www.django-cms.org/en/repositories-plugins/
Other
46 stars 46 forks source link

merge 4.0.1.x branch to master: make snippet component versioning #166

Open joshyu opened 2 months ago

joshyu commented 2 months ago

Hi team,

Recently we are about to upgrade our CMS version to 4.1.2, but we still need the feature of making snippet versioning. Currently all of the versioning related changes are in the branch support/django-cms-4.0.x. Is it possible to merge this branch to master? we can cherry-pick and merge every meaningful changes.

@fsbraun , @Aiky30 , please provide your input.

fsbraun commented 2 months ago

@joshyu what's your opinion on https://github.com/django-cms/djangocms-snippet/pull/160? Snippets for everyone?

joshyu commented 2 months ago

@fsbraun, Cool. I missed this PR. it's just what we want. I will give it a test and give you my feedback.

joshyu commented 2 months ago

Hi @fsbraun ,

I installed this PR branch to djangocms-quickstart for a test, but failed to build web image.

image

I found that the template folder and internal files are missing from the directory tree.

image

Can you please check it?