Issues when using HTMLField not in full-screen mode - link dialogue not positioned correctly

[petrklus]

Steps to reproduce:

• Open Text plugin or any other custom plugin using HTMLField
• (if using Text plugin) exit the full-screen mode
• Open link dialogue

The issue is further exacerbated in custom plugins where the HTMLField is not at the top, as it forces the whole plugin iframe to scroll to the top when the link dialogue is activated, scrolling the HTMLField that is being interacted with out of view.

https://user-images.githubusercontent.com/1115667/192570444-93575fc1-51e9-4535-9476-5932d774ef6b.mov

Reproduced on Divio with clean Django CMS install and following package versions:

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This will now be closed due to inactivity, but feel free to reopen it.

[petrklus]

@fsbraun can we please re-open this issue? Still the same problem.

[fsbraun]

I fear it's a ckeditor problem. I believe the ckeditor plugins are not under control of djangocms-text-ckeditor.

[fsbraun]

Since I cannot reproduce the situation where the ckeditor dialogue scrolls an iframe to the top, can you share a demonstration of that? In the animation above it seems the link dialogue is centered within the field being edited.

[petrklus]

@fsbraun here it can be seen a bit better: https://user-images.githubusercontent.com/1115667/220878351-30a172ab-5eb4-4c69-9c95-b765fb8ae799.mov

You can see that the link dialogue does not centre unless it's repositioned. This is a new bug after upgrading to 5.x, it was not an issue with 3.9.1

At a :17s mark you can also see how it "jumps" the plugin editor to the top. Not a huge issue in this case as the HTMLField is at the top, becomes more of an issue if the field is more lower down.

[fsbraun]

@petrklus OK, now I can see what happens. Can you for testing purpose replace the file djangocms-text-ckeditor/djangocms_text_ckeditor/static/djangocms_text_ckeditor/ckeditor_plugins/cmsdialog/plugin.js with this version?

If this does not change anything, I assume it must be the ckeditor version. It used to be 4.7 or so and is at 4.17 now?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This will now be closed due to inactivity, but feel free to reopen it.