django-cms / djangocms-text-ckeditor

Text Plugin for django CMS using CKEditor 4
https://www.django-cms.org/en/repositories-plugins/
BSD 3-Clause "New" or "Revised" License
167 stars 185 forks source link

Updated ckeditor to v4.21.0 #640

Closed sgordeychuk closed 1 year ago

sgordeychuk commented 1 year ago

The main reason of this upgrade was the fix of CVE-2022-24728 ckeditor vulnerability (which worries many people and vulnerability testing tools), but ckeditor builder doesn't allow to just pick version 4.18, so I've upgraded to the latest.

I've tested it in one of ours django cms projects, although I'm not sure how I can share the test results. Please let me know if any additional steps should be taken to test the upgrade.

I've also ran tests using python setup.py test for dj32_cms311 and dj41_cms41 envs, the results are:

Ran 47 tests in 1.071s

OK (skipped=5)
fsbraun commented 1 year ago

@sgordeychuk Thanks a lot! We might need to get the latest moono-lisa skin patched to work with dark mode. Can you check locally if the ckeditor skin turns into dark mode if used? The editor is built by running gulp build.

codecov[bot] commented 1 year ago

Codecov Report

Merging #640 (52a76aa) into master (3478dfb) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #640   +/-   ##
=======================================
  Coverage   76.18%   76.18%           
=======================================
  Files          20       20           
  Lines         932      932           
  Branches      124      124           
=======================================
  Hits          710      710           
  Misses        196      196           
  Partials       26       26           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sgordeychuk commented 1 year ago

thanks a lot @fsbraun ! I saw your comment but didn't have a chance to take a look at it, sorry