search

django-cms / djangocms-text-ckeditor

Text Plugin for django CMS using CKEditor 4
https://www.django-cms.org/en/repositories-plugins/
BSD 3-Clause "New" or "Revised" License
167 stars 185 forks source link

create_picture_plugin incompatible with djangocms-picture 2+ #642

Closed leture closed 7 months ago

leture commented 1 year ago

Hi,

according to https://github.com/django-cms/djangocms-picture/blob/master/CHANGELOG.rst#200-2016-09-08 djangocms-picture (specifically "Migrate model field image to FilerImageField and renamed to picture") I assume the current create_picture_plugin implementation does not work properly with djangocms-picture 2.0.0 or higher.

The current implementation sets pic.image = path but would need to set pic.picture = some_FilerImage_instance I assume. Do I miss something here or is my observation valid? If my observation is valid, is there interest in fixing this? If so I would create a pull request then.

Greetings

fsbraun commented 1 year ago

It would be great if you could fix that issue!

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

fsbraun commented 1 year ago

@leture Can I still interest you in crating this Pull Request? Would be awesome!

leture commented 10 months ago

@fsbraun Sorry for the delay but I finally found the time to do it :-)

stale[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.