search

django-cms / djangocms-text-ckeditor

Text Plugin for django CMS using CKEditor 4
https://www.django-cms.org/en/repositories-plugins/
BSD 3-Clause "New" or "Revised" License
164 stars 186 forks source link

Fix update notification on latest foss version of ckeditor 4.22.*. #668

Closed corentinbettiol closed 3 weeks ago

corentinbettiol commented 5 months ago

Hi. Ckeditor started to show a notification yesterday: image

It's a problem because it shows on every ckeditor box, even the ones who are part of a form on a public-facing website: every visitor of the site will see this.

image

Since we can't use versions 4.23+ (those are lts versions, which needs a license key to work, they changed the license), what we can do as a temporary fix is simply remove the notification process on the ckeditor code (gnu gpl3, we're allowed to make changes to the program).

matthiask commented 4 months ago

https://github.com/django-ckeditor/django-ckeditor/commit/d1cd092b4fbfb0534ded7f09a219d89fea5e547f Here's a different fix. All you have to do is versionCheck:false in the configuration. That being said, 4.22.1 is already known to be insecure, therefore hiding the notification isn't really fixing anything.

fsbraun commented 4 months ago

@matthiask Thank you very much for the hint!! I like the system check warning.

corentinbettiol commented 4 months ago

Thank you for this fix @matthiask!

stale[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 weeks ago

This will now be closed due to inactivity, but feel free to reopen it.