search

django-cms / djangocms-text-ckeditor

Text Plugin for django CMS using CKEditor 4
https://www.django-cms.org/en/repositories-plugins/
BSD 3-Clause "New" or "Revised" License
164 stars 186 forks source link

Fix: hide notification #669

Closed corentinbettiol closed 1 month ago

corentinbettiol commented 5 months ago

As explained in #668, ckeditor started showing notifications about the current version being "insecure". This PR removes the code making it check the version and show the notification.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.79%. Comparing base (fea95ed) to head (36c1e9a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #669 +/- ## ======================================= Coverage 81.79% 81.79% ======================================= Files 20 20 Lines 912 912 Branches 122 122 ======================================= Hits 746 746 Misses 138 138 Partials 28 28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fsbraun commented 5 months ago

@corentinbettiol Can you build the ckeditor.js file uncompressed (./dev/builder/build.sh --leave-js-unminified command, I believe)? All CKeditor licenses require the source to be distributed along with a modified version. It will be minified when building the bundle (using gulp bundle).

corentinbettiol commented 5 months ago

@fsbraun I just took the file content from cdn.jsdelivr.net/npm/ckeditor4@4.22.1/ckeditor.js, formatted it, removed the notification code, and re-minified it.

All CKeditor licenses require the source to be distributed along with a modified version. It will be minified when building the bundle (using gulp bundle).

I don't understand this part. The content of the file on the master branch is minified.

fsbraun commented 5 months ago

@corentinbettiol Sorry, for being unclear. Yes, the distributed versions of ckeditor4 are minified. But since we're about to change it, the license requires a "source". As described in https://github.com/django-cms/djangocms-text-ckeditor/blob/master/UPGRADE.md , could you try building ckeditor4 from source (non-minified) and then remove the warning code?

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 month ago

This will now be closed due to inactivity, but feel free to reopen it.