django-cms / djangocms-text-ckeditor

Text Plugin for django CMS using CKEditor 4
https://www.django-cms.org/en/repositories-plugins/
BSD 3-Clause "New" or "Revised" License
167 stars 185 forks source link

BUG - Color Popup "OK" Button/dialog closes table cell popup/dialog #672

Closed s4ke closed 1 month ago

s4ke commented 5 months ago

We use the editor in a page that has tables in it. When we want to change the background color of a cell, we go to the cell settings:

grafik

then, we click on background color:

grafik

select color, click on OK.

Cell editor is gone and page has a gray overlay and we can't edit anymore:

grafik

My hunch says that there is something wired up weirdly either in our app, or in one of the recentupdates of this package that causes the second popup to close all existing popups. Would be awesome, if you could give us some pointers how we could improve this situation.

We are on the latest version of djangocms-text-ckeditor (5.1.5).

fsbraun commented 5 months ago

How do you get to cell settings?

s4ke commented 5 months ago

we right click on a cell:

grafik

fsbraun commented 5 months ago

Are you using the bundled version of ckeditor? I do not have this menu entry. Not sure why.

s4ke commented 5 months ago

We are using the bundled version as far as I can tell. This is our CKEDITOR_SETTINGS config:

CKEDITOR_SETTINGS = {
    'language': '{{ language }}',
    'skin': 'moono',
    'toolbar_CMS': [
        ['Undo', 'Redo'],
        ['cmsplugins', 'cmswidget', '-', 'ShowBlocks'],
        ['Format', 'Styles'],
        ['TextColor', 'BGColor', '-', 'PasteText', 'PasteFromWord', '-', 'Scayt'],
        ['Find', 'Replace'],
        ['Maximize', ''],
        '/',
        ['FontSize', 'Bold', 'Italic', 'Underline', '-', 'Subscript', 'Superscript', '-', 'CopyFormatting', 'RemoveFormat', '-', 'SpecialChar','Image'],
        ['JustifyLeft', 'JustifyCenter', 'JustifyRight', 'JustifyBlock'],
        ['HorizontalRule'],
        ['NumberedList', 'BulletedList', '-', 'Outdent', 'Indent', '-', 'Blockquote', 'CreateDiv', '-', 'Table','AddLayout'],
        ['Source'],
    ],
    'toolbar_HTMLField': [
        ['Undo', 'Redo'],
        ['ShowBlocks'],
        ['Format', 'Styles'],
        ['TextColor', 'BGColor', '-', 'PasteText', 'PasteFromWord', '-', 'Scayt'],
        ['Find', 'Replace'],
        ['Maximize', ''],
        '/',
        ['FontSize', 'Bold', 'Italic', 'Underline', '-', 'Subscript', 'Superscript', '-', 'CopyFormatting', 'RemoveFormat', '-', 'SpecialChar','Image'],
        ['JustifyLeft', 'JustifyCenter', 'JustifyRight', 'JustifyBlock'],
        ['HorizontalRule'],
        ['Link', 'Unlink'],
        ['NumberedList', 'BulletedList', '-', 'Outdent', 'Indent', '-', 'Blockquote', 'CreateDiv', '-', 'Table','AddLayout'],
        ['Source'],
    ],
    'extraPlugins': 'wordcount,notification,layoutmanager,dialogadvtab,colordialog,table,tabletools,tableresize,tableselection',
    'layoutmanager_loadbootstrap': True,
    'scayt_autoStartup': True,
    'scayt_sLang': 'de_DE',
    'fontSize_sizes': "Extra klein/1.2rem;Klein/1.5rem;Normal/1.8rem;Gross/2.1rem;Extra gross/2.4rem;",
}

Seems to be coming from tabletools? https://ckeditor.com/cke4/addon/tabletools

fsbraun commented 5 months ago

Yes, it seems. They're not part of the bundled ckeditor. I cannot judge if the issue is in the table tools. There also might be some side effect with the cmsdialog plugin which comes with djangocms-text-ckeditor. Do you see any change if you add removePlugins: "cmsdialog" to the CKEDITOR_SETTINGS? I am not sure this is sufficient to keep the cmsdialog from loading. You might want to check the browser's network history.

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 month ago

This will now be closed due to inactivity, but feel free to reopen it.