search

django-cms / djangocms-transfer

django CMS Transfer allows you to export and import plugins.
https://www.django-cms.org
Other
19 stars 19 forks source link

make export filenames a bit more unique #15

Closed arneb closed 11 months ago

arneb commented 3 years ago

Working a lot with the app makes it cumbersome to rename export-files because they all have the same name.

This PR proposes a solution where the page slug, the placeholder name and the plugin short description are used depending on the level of the export to name the file in a more unique way.

codecov-io commented 3 years ago

Codecov Report

Merging #15 (4938f80) into master (2eb1e33) will decrease coverage by 0.41%. The diff coverage is 9.09%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   32.19%   31.79%   -0.41%     
==========================================
  Files          11       11              
  Lines         382      390       +8     
  Branches       56       57       +1     
==========================================
+ Hits          123      124       +1     
- Misses        259      266       +7
Files Changed Coverage Δ
djangocms_transfer/forms.py 24.03% <9.09%> (-0.97%) :arrow_down:
peacefulseeker commented 2 years ago

@arneb , any further plans to review/merge that? That feature would be very useful.

marksweb commented 2 years ago

@arneb @peacefulseeker hi, I discovered this just recently. Need to find some time to review & merge 👍

LuckyType commented 11 months ago

@marksweb I rebased this onto master, updates on this would be very nice.