search

django-cms / djangocms-url-manager

Other
5 stars 14 forks source link

Updating model URLs broken #27

Closed adam-murray closed 4 years ago

adam-murray commented 4 years ago

When updating a model it is not possible to change the type of URL. i.e. if a saved model instance is linked to a page it is not possible to change to a manual URL. - if this is an intended feature there should be feedback.

adam-murray commented 4 years ago

This is due to the expectation that one (and only one) of the fields to contain types of URL should be populated.

The get_url method in models.py returns the url corresponding to the last type checked for, meaning it may be incorrect.

Changes to the custom save method would fix this.

adam-murray commented 4 years ago

PR: https://github.com/divio/djangocms-url-manager/pull/29

Aiky30 commented 4 years ago

Fix merged