Closed marksweb closed 1 year ago
Merging #291 (4389dce) into master (914cd32) will decrease coverage by
2.26%
. The diff coverage is50.00%
.:exclamation: Current head 4389dce differs from pull request most recent head 532e99f. Consider uploading reports for the commit 532e99f to get more accurate results
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
- Coverage 86.39% 84.12% -2.27%
==========================================
Files 23 23
Lines 801 838 +37
Branches 118 117 -1
==========================================
+ Hits 692 705 +13
- Misses 82 107 +25
+ Partials 27 26 -1
Impacted Files | Coverage Δ | |
---|---|---|
djangocms_versioning/monkeypatch/page.py | 61.11% <45.83%> (-10.69%) |
:arrow_down: |
djangocms_versioning/monkeypatch/extensions.py | 57.35% <53.33%> (-10.04%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
That check failure can't be avoided. The extra code is going to make the coverage drop, but I guess it's a temporary change.
This brings compatibility for the current cms v4 setup and the changes I've introduced with;
https://github.com/django-cms/django-cms/pull/7369
And I've included some basic pre-commit hooks for linters to help avoid issues at the point of github actions.
This probably wants to come in with a major version bump