Closed fsbraun closed 1 year ago
Merging #295 (ed3e907) into master (fedd956) will increase coverage by
0.00%
. The diff coverage is82.00%
.:exclamation: Current head ed3e907 differs from pull request most recent head 58222a9. Consider uploading reports for the commit 58222a9 to get more accurate results
@@ Coverage Diff @@
## master #295 +/- ##
=======================================
Coverage 85.17% 85.17%
=======================================
Files 23 24 +1
Lines 843 931 +88
Branches 118 141 +23
=======================================
+ Hits 718 793 +75
- Misses 100 108 +8
- Partials 25 30 +5
Impacted Files | Coverage Δ | |
---|---|---|
djangocms_versioning/monkeypatch/templatetags.py | 58.82% <50.00%> (+5.88%) |
:arrow_up: |
djangocms_versioning/indicators.py | 80.00% <80.00%> (ø) |
|
djangocms_versioning/cms_toolbars.py | 95.70% <93.10%> (-0.01%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This pull request introduces 1 alert when merging 500f79fdff57c3db775601c92e3a3633ceacaca2 into e6a33eac1a1ce6c82810da4eff9e5397394604a4 - view on LGTM.com
new alerts:
Like the look of this. Will have to try it out 👍
@marksweb Only works together with https://github.com/django-cms/django-cms/pull/7426 (gulp sass && gulp bundle
for the full experience...)
This pull request introduces 1 alert when merging bfcb5d9df3777a78195004da2df65608f5ecd9d0 into 84c063d4f13ffed4c3bb76eaa76c5003e6d19241 - view on LGTM.com
new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed :rocket:. For more information, please check out our post on the GitHub blog.
This pull request introduces 2 alerts when merging 1311e81596c1bf94615b209b5a6622f8252fbb3d into 84c063d4f13ffed4c3bb76eaa76c5003e6d19241 - view on LGTM.com
new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed :rocket:. For more information, please check out our post on the GitHub blog.
This pull request introduces 1 alert when merging 4a029e2a1d1af4db82d342e2ecb8ce1b59a4275c into 84c063d4f13ffed4c3bb76eaa76c5003e6d19241 - view on LGTM.com
new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed :rocket:. For more information, please check out our post on the GitHub blog.
This pull request introduces 1 alert when merging ed3e907727bd81ce02bd8b76a919312e1bf5b0bb into 84c063d4f13ffed4c3bb76eaa76c5003e6d19241 - view on LGTM.com
new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed :rocket:. For more information, please check out our post on the GitHub blog.
This pull request introduces 1 alert when merging 58222a9dd4b6d9446c20771903539db2308ec1e5 into fedd9563827180762077f6383bc90a8b8100a7cc - view on LGTM.com
new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed :rocket:. For more information, please check out our post on the GitHub blog.
Description
This pr adds the capability to monkey patch the page trees indicator menu allowing to publish, unpublish, and revert from the page tree.
This PR is draft and open points remain to be done
Related resources
...
Review guide
monkeypatch/indicators.py
: Indicator logic, patching into classy template tags. Since template tags are called multiple times, versioning results are cachedmonkeypatch/templatetags.py
: Backward compatibility: Patches function-based tags (v4.0....) or class-based tags (v4.1....)cms_toolbar.py
: Show edit button only if edit is possible (otherwise clicking produces an error), show revert button if viewing archive or unpublished versionChecklist
master