Closed fsbraun closed 1 year ago
Merging #298 (c9d5040) into master (31f14df) will increase coverage by
0.24%
. The diff coverage is95.65%
.
@@ Coverage Diff @@
## master #298 +/- ##
==========================================
+ Coverage 86.60% 86.85% +0.24%
==========================================
Files 23 23
Lines 799 829 +30
Branches 105 106 +1
==========================================
+ Hits 692 720 +28
- Misses 81 82 +1
- Partials 26 27 +1
Impacted Files | Coverage Δ | |
---|---|---|
djangocms_versioning/monkeypatch/page.py | 74.41% <77.77%> (-1.26%) |
:arrow_down: |
djangocms_versioning/monkeypatch/admin.py | 83.01% <100.00%> (+1.38%) |
:arrow_up: |
djangocms_versioning/monkeypatch/extensions.py | 70.00% <100.00%> (+2.60%) |
:arrow_up: |
djangocms_versioning/monkeypatch/menu.py | 100.00% <100.00%> (ø) |
|
djangocms_versioning/monkeypatch/templatetags.py | 72.22% <100.00%> (+7.93%) |
:arrow_up: |
djangocms_versioning/monkeypatch/toolbar.py | 100.00% <100.00%> (ø) |
|
djangocms_versioning/monkeypatch/wizard.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This pull request introduces 1 alert when merging a69248da7923a19801a5954838ab59e2c85e7a4a into 31f14df4a7624d4be60282c11ec38f0108026e69 - view on LGTM.com
new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed :rocket:. For more information, please check out our post on the GitHub blog.
Description
This PR implements the patching API for django CMS v4 (https://github.com/django-cms/django-cms/pull/7439) for djangocms-versioning in a backward compatible way.
The patching API requires functions, methods, or properties that are patched to be marked by the
@patch_hook
decorator. Trying to patch functions, methods, or properties that are no marked will raise anImproperlyConfigured
exception.This is a precaution to ensure developers of the core are aware of patch hooks and to prevent injection of side-effects in the future as far as possible.
Related resources
Checklist
master