django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.
Other
33 stars 29 forks source link

feat: Use same icons in page tree state indicators and Manage verisons #302

Closed fsbraun closed 1 year ago

fsbraun commented 1 year ago

Description

This PR reuses the icons of the django CMS core (which are loaded anyways) for the "Manage Verions" admin view. This creates a more uniform look and feel.

Before (with djangocms-versioning icons): Bildschirmfoto 2022-12-15 um 09 26 22

After (with django-cms core icons): Bildschirmfoto 2022-12-15 um 09 27 59

Related resources: icons of django CMS core

Bildschirmfoto 2022-12-15 um 09 32 01

codecov[bot] commented 1 year ago

Codecov Report

Merging #302 (c61f1e4) into master (3e6fb53) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files          30       30           
  Lines        1743     1743           
  Branches      269      269           
=======================================
  Hits         1515     1515           
  Misses        173      173           
  Partials       55       55           
Impacted Files Coverage Δ
djangocms_versioning/admin.py 88.76% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.