django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.
Other
34 stars 30 forks source link

Some fixed strings are now translatable #310

Closed svandeneertwegh closed 1 year ago

svandeneertwegh commented 1 year ago

Description

constants.py = 4 fixed strings which dit not parsed through _() models.py = 2 date fields which did not had verbose_name

codecov[bot] commented 1 year ago

Codecov Report

Merging #310 (3f9705a) into master (b77ef6f) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          68       68           
  Lines        2242     2242           
  Branches      299      299           
=======================================
  Hits         2015     2015           
  Misses        172      172           
  Partials       55       55           
Impacted Files Coverage Δ
djangocms_versioning/models.py 94.85% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fsbraun commented 1 year ago

@svandeneertwegh Can you please run django-admin makemessages --all in the djangocms_versioning folder and include the update po files in the PR?