django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.
Other
33 stars 29 forks source link

fix: Minor usability improvements #317

Closed fsbraun closed 1 year ago

fsbraun commented 1 year ago

Description

Ajax error message in page tree

Since django CMS 4.1.0rc1 the page tree shows error messages returned by ajax post requests such as toggling navigation status of a page content object.

No additional message needs not to be sent to the front end. It only results in the error message shown again after a reload.

Edit button renamed to "New Draft" if the action creates a new draft (as opposed to go into editing mode of an existing draft)

To avoid accidental creation of many draft objects by clicking the Edit button in the toolbar this PR renames the Edit button to "New Draft" if by clicking it a new draft will be created. image

Menu item "Discard changes" in versioning menu

This replaces v3's "Revert to published" function by calling the discard view (without the need of going through "Manage versions") image

Replace deprecated icons

Related resources

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #317 (212dacf) into master (65f6da9) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   89.91%   89.96%   +0.05%     
==========================================
  Files          68       68              
  Lines        2251     2253       +2     
  Branches      300      300              
==========================================
+ Hits         2024     2027       +3     
+ Misses        172      171       -1     
  Partials       55       55              
Impacted Files Coverage Δ
djangocms_versioning/admin.py 88.76% <ø> (ø)
djangocms_versioning/cms_config.py 80.59% <ø> (+0.30%) :arrow_up:
djangocms_versioning/helpers.py 91.11% <ø> (ø)
djangocms_versioning/indicators.py 80.00% <ø> (ø)
djangocms_versioning/cms_toolbars.py 95.95% <100.00%> (+0.09%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.