django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.
Other
33 stars 29 forks source link

fix: burger menu to also work with new core icons #323

Closed fsbraun closed 1 year ago

fsbraun commented 1 year ago

Description

This PR fixes the burger menu to

  1. work with icons provided by the core
  2. variable width content
  3. Only display if there are elements in the burger menu
  4. CMS style (same as e.g., state indicator drop down or page tree dropdowns)

Example djangocms-admin-style

image

Example bare django admin

image

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #323 (5ed516c) into master (1e8a48c) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files          68       68           
  Lines        2324     2324           
  Branches      314      314           
=======================================
  Hits         2104     2104           
  Misses        165      165           
  Partials       55       55           
Impacted Files Coverage Δ
djangocms_versioning/admin.py 89.13% <ø> (ø)
djangocms_versioning/indicators.py 91.07% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.