django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.
Other
33 stars 29 forks source link

fix: Modify language menu for pages only if it is present #333

Closed fsbraun closed 1 year ago

fsbraun commented 1 year ago

Description

Pages do not need to have language menus (even if USE_I18N is True). Trying to modify a non-existing menu leads to an attribute error.

This PR also runs makemessages and includes updated .mo files.

Finally, the locale path is included in the manifest for future packaging.

Steps to reproduce

Related resources

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #333 (f1d6737) into master (91eafe1) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files          72       72           
  Lines        2536     2536           
  Branches      358      358           
=======================================
  Hits         2306     2306           
  Misses        170      170           
  Partials       60       60           
Impacted Files Coverage Δ
djangocms_versioning/cms_toolbars.py 96.90% <100.00%> (ø)
marksweb commented 1 year ago

I'll install and test this in the morning 👍