Open fsbraun opened 1 year ago
Attention: Patch coverage is 23.52941%
with 13 lines
in your changes are missing coverage. Please review.
Project coverage is 91.15%. Comparing base (
f90c5b2
) to head (b04488e
). Report is 13 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
djangocms_versioning/datastructures.py | 23.52% | 11 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Versioning allows specifying a copy method to allow for copying foreign keys, one-to-one fields in a meaningful way for the specific model.
One of the most relevant relations will be placeholders and their plugins.
To avoid code repetition of largely identical copy methods in any package using djangocms-versioning, I propose to include coyping placeholders in versioned models by default.
This would make custom copy functions obsolete in alias and blog and other content objects to come.
Also, if the verisoned model has a method
copy_relations
it is called on the new object allowing to keep simple copy information within the model.Tests follow.
Related resources
...
...
Checklist
master