django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.
Other
34 stars 30 forks source link

Fix tests #349

Closed FinalAngel closed 1 year ago

FinalAngel commented 1 year ago

Description

Related resources

This fixes the ruff tests not passing

fsbraun commented 1 year ago

@FinalAngel I believe there needs to hyphens instead of spaces here for tests to pass: https://github.com/django-cms/djangocms-versioning/blob/c833c65ca8397e0990dec9e02592503f677229cb/tests/test_cms_config.py#L110 (I just updated with those changes in the main branch.)

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ad24c93) 90.93% compared to head (0b9b470) 90.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #349 +/- ## ======================================= Coverage 90.93% 90.93% ======================================= Files 72 72 Lines 2536 2536 Branches 357 357 ======================================= Hits 2306 2306 Misses 170 170 Partials 60 60 ``` | [Files Changed](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms) | Coverage Δ | | |---|---|---| | [djangocms\_versioning/cms\_config.py](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX3ZlcnNpb25pbmcvY21zX2NvbmZpZy5weQ==) | `80.82% <ø> (ø)` | | | [djangocms\_versioning/helpers.py](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX3ZlcnNpb25pbmcvaGVscGVycy5weQ==) | `91.39% <ø> (ø)` | | | [djangocms\_versioning/admin.py](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX3ZlcnNpb25pbmcvYWRtaW4ucHk=) | `90.70% <100.00%> (ø)` | | | [djangocms\_versioning/cms\_toolbars.py](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX3ZlcnNpb25pbmcvY21zX3Rvb2xiYXJzLnB5) | `96.90% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.