django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.
Other
34 stars 30 forks source link

fix: Update templates for better styling w/o djangocms-admin-style #352

Closed fsbraun closed 1 year ago

fsbraun commented 1 year ago

Description

This PR adds the .submit-row <div> used in Django admin for more consistent styling.

It also removes an unused left-over helper function (legacy of pre-2.0):

Related resources

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.21% :tada:

Comparison is base (5944cff) 90.69% compared to head (3204c1b) 90.90%.

:exclamation: Current head 3204c1b differs from pull request most recent head bf1c6bf. Consider uploading reports for the commit bf1c6bf to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #352 +/- ## ========================================== + Coverage 90.69% 90.90% +0.21% ========================================== Files 72 72 Lines 2536 2530 -6 Branches 357 356 -1 ========================================== Hits 2300 2300 + Misses 175 170 -5 + Partials 61 60 -1 ``` | [Files Changed](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms) | Coverage Δ | | |---|---|---| | [djangocms\_versioning/helpers.py](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX3ZlcnNpb25pbmcvaGVscGVycy5weQ==) | `91.11% <100.00%> (-0.29%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/352/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.