django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.
Other
33 stars 29 forks source link

ci: Add testing against django main #353

Closed marksweb closed 8 months ago

marksweb commented 1 year ago

This adds testing against django's main branch.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ecac82f) 90.88% compared to head (9bcb377) 90.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #353 +/- ## ======================================= Coverage 90.88% 90.88% ======================================= Files 72 72 Lines 2546 2546 Branches 361 361 ======================================= Hits 2314 2314 Misses 168 168 Partials 64 64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fsbraun commented 1 year ago

@marksweb You'll need to also swap installation of requirements and django main branch.

fsbraun commented 1 year ago

@marksweb Should we test the Django main branch with django CMS develop-4 ?

fsbraun commented 10 months ago

@marksweb Does it make sense to run the py3.12 against develop-4 for the time being?

marksweb commented 10 months ago

@fsbraun not if support might take a while.

fsbraun commented 10 months ago

I think it's there.

fsbraun commented 9 months ago

@marksweb I added the following lines to the three test files that use assertQuerySetEqual just after the imports:

if not hasattr(CMSTestCase, "assertQuerySetEqual"):
    # Django < 4.2
    CMSTestCase.assertQuerySetEqual = CMSTestCase.assertQuerysetEqual

Might be easier to remove later...