fix: Preview link language

fsbraun commented 8 months ago

Description

This PR fixes an issue with the preview links falling back to the primary language.

No more jumping between languages when clicking preview in the version admin
Comparing pages not of the primary language works

Related resources

...
...

Checklist

[ ] I have opened this pull request against master
[ ] I have added or modified the tests when changing logic
[ ] I have followed the conventional commits guidelines to add meaningful information into the changelog
[ ] I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (97f2801) 90.86% compared to head (5a41f0e) 90.95%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #357 +/- ## ========================================== + Coverage 90.86% 90.95% +0.08% ========================================== Files 72 72 Lines 2530 2533 +3 Branches 356 356 ========================================== + Hits 2299 2304 +5 + Misses 170 168 -2 Partials 61 61 ``` | [Files](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms) | Coverage Δ | | |---|---|---| | [djangocms\_versioning/admin.py](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX3ZlcnNpb25pbmcvYWRtaW4ucHk=) | `90.75% <100.00%> (+0.05%)` | :arrow_up: | | [djangocms\_versioning/cms\_config.py](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX3ZlcnNpb25pbmcvY21zX2NvbmZpZy5weQ==) | `80.36% <100.00%> (ø)` | | | [djangocms\_versioning/cms\_menus.py](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX3ZlcnNpb25pbmcvY21zX21lbnVzLnB5) | `79.38% <ø> (ø)` | | | [djangocms\_versioning/indicators.py](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX3ZlcnNpb25pbmcvaW5kaWNhdG9ycy5weQ==) | `98.18% <ø> (+6.51%)` | :arrow_up: | | [djangocms\_versioning/helpers.py](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX3ZlcnNpb25pbmcvaGVscGVycy5weQ==) | `90.27% <60.00%> (-0.85%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marksweb commented 7 months ago

Ok the change here looks good. We just need some further fixes for 3.12 so maybe that should be it's own PR to introduce that and fix the issues so we get a clean run of checks for this?

fsbraun commented 7 months ago

@marksweb @vinitkumar The 3.12 issues reside in django-app-helper. From my side we can merge this.

marksweb commented 7 months ago

Ok that's fair 👍

django-cms / djangocms-versioning