Closed fsbraun closed 6 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
0d5b461
) 90.95% compared to head (de69f81
) 90.84%.
Files | Patch % | Lines |
---|---|---|
djangocms_versioning/admin.py | 68.75% | 3 Missing and 2 partials :warning: |
djangocms_versioning/helpers.py | 66.66% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@marksweb I've fixed the tests for this. For py3.12 they keep failing due to the django-app-helper dependency.
Description
Currently, upon publishing a page (or other content object) the user is redirected to the version admin of that object. This is excellent for power users.
This PR adds the setting
DJANGOCMS_VERSIONING_ON_PUBLISH_REDIRECT
with three possible values:"published"
: Redirects to the objects.get_absolute_url()
(if available, preview endpoint otherwise). This is close to v3's behaviour and potentially a good setting for an occasional editor."preview"
: Redirects to the object's preview endpoint, just as most other user interactions."versions"
: Redirects to the object's version list (as before)The default is
"published"
.This is a draft PR. Tests will work, once #357 is merged.
Related resources
357
...
Checklist
master