fix #363: Better UX in versioning listview

django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.

Other

33 stars 29 forks source link

fix #363: Better UX in versioning listview #364

Closed jrief closed 3 months ago

jrief commented 6 months ago

Description

Fixes #363

Allow max two checked checkboxes when comparing versions.

Checklist

[x] I have opened this pull request against master
[ ] I have added or modified the tests when changing logic
[ ] I have followed the conventional commits guidelines to add meaningful information into the changelog
[ ] I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

This pull request is for review and testing. I actually don't know how to add a unit test since it's client functionality only.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.89%. Comparing base (f90c5b2) to head (5ef01fc). Report is 4 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #364 +/- ## ======================================= Coverage 90.88% 90.89% ======================================= Files 72 72 Lines 2546 2548 +2 Branches 361 361 ======================================= + Hits 2314 2316 +2 Misses 168 168 Partials 64 64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fsbraun commented 6 months ago

Great idea! I am going to test the UX.

One thought comes to my mind ahead of time: There might be other bulk actions in the future which might require more than 2 versions selected. To make this PR future-proof, would it be possible to check if the option value="compare_versions" is the only one?