Confusing statement in `djangocms_versioning/admin.py`

django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.

Other

33 stars 29 forks source link

Confusing statement in `djangocms_versioning/admin.py` #382

Closed jrief closed 3 months ago

jrief commented 4 months ago

This statement is confusing https://github.com/django-cms/djangocms-versioning/blob/a70c194c27c5aadb58f07e42309613ca7952daa8/djangocms_versioning/admin.py#L974 because redirect_url always is None.

fsbraun commented 4 months ago

Agree. This is a bug. Line 972 needs to go. In case the published content does not have an absolute url, redirect_url then will point to the preview endpoint, which must exist.