django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.
Other
33 stars 29 forks source link

Unpublishing a page from the sidebar does not close the sidebar #383

Closed jrief closed 3 months ago

jrief commented 4 months ago

How to reproduce:

Extra observations I made: When clicking on the "Preview", "Publish" or "Revert" button in the list of page content versions, the click-event-listener in /static/cms/js/admin/actions.js is called which in turn calls the function closeSideFrame(). On the other side, unpublishing a page first renders a confirmation dialog. But here the "Yes, I'm sure" button is not connected to any event handler. Hence the function closeSideFrame() is never called, leaving the side frame open forever.

I believe that the "Yes, I'm sure" button just requires one of the additional CSS classes js-action, cms-js-edit-btn or cms-actions-dropdown-menu-item-anchor, in order to connect that event handler. Which classes should I use and is this the intended behaviour to close the side frame after clicking on that button?

fsbraun commented 3 months ago

Fixed in #386