search

django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.
Other
34 stars 30 forks source link

fix: For Django CMS 4.1.1 and later do not automatically register versioned CMS Menu #388

Closed fsbraun closed 8 months ago

fsbraun commented 8 months ago

Description

As of django CMS 4.1.1, the django CMS core comes with a versioning-ready CMS Menu which

This PR changes the default value of the setting DJANGOCMS_VERSIONING_ENABLE_MENU_REGISTRATION from True (CMS <= 4.1.0) to False.

Projects which set DJANGOCMS_VERSIONING_ENABLE_MENU_REGISTRATION are not affected by this PR.

Projects relying on the default setting will switch to the faster CMS Menu of the django CMS core if at least version 4.1.1 is installed.

Related resources

Checklist

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.89%. Comparing base (f90c5b2) to head (a917662). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #388 +/- ## ======================================= Coverage 90.88% 90.89% ======================================= Files 72 72 Lines 2546 2548 +2 Branches 361 361 ======================================= + Hits 2314 2316 +2 Misses 168 168 Partials 64 64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vinitkumar commented 8 months ago

@fsbraun You might want to run ruff once to pass the code lint.

fsbraun commented 8 months ago

Ruff has added a rule ...

vinitkumar commented 8 months ago

Ruff has added a rule ...

You probably need to upgrade ruff and run it --fix so autofix it.

fsbraun commented 8 months ago

Yeah, no autofix for UP032...