Feat/django 42 compatible

django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.

Other

33 stars 29 forks source link

Feat/django 42 compatible #389

Closed vipulnarang95 closed 3 months ago

vipulnarang95 commented 3 months ago

Description

Django 4.2 support added. removed support for django <3.2

Related resources

Checklist

[ ] I have opened this pull request against master
[ ] I have added or modified the tests when changing logic
[ ] I have followed the conventional commits guidelines to add meaningful information into the changelog
[ ] I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.33%. Comparing base (31f14df) to head (fa54a30).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## support/django-cms-4.0.x #389 +/- ## ============================================================ - Coverage 86.60% 84.33% -2.28% ============================================================ Files 23 71 +48 Lines 799 2145 +1346 Branches 105 252 +147 ============================================================ + Hits 692 1809 +1117 - Misses 81 273 +192 - Partials 26 63 +37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joshyu commented 3 months ago

@fsbraun / @Aiky30 , I am new to codeconv issue, I have no idea how to fix this codeconv error. Is there any reference or guidance for me to follow?

fsbraun commented 3 months ago

@joshyu This “fails” since test coverage went down by 2.28%. Looking at the detailed report, it seems spurious to me. You did not add 48 files or 1346 lines of code, did you? For me this should not block merging the PR.

joshyu commented 3 months ago

@fsbraun / @Aiky30 ,

Yes, you can check all of the changed files, we only update some code to make them compatible with django 4.2 Perhaps the code coverage already doesn't meet the requirement before we raise this PR.

If OK, please help to review our change. Thanks.