feat: Optimize db evaluation - Githubissues

django-cms / djangocms-versioning

General purpose versioning package for Django CMS 4 and above.

Other

34 stars 30 forks source link

feat: Optimize db evaluation #416

Closed fsbraun closed 4 months ago

fsbraun commented 4 months ago

Description

This PR halves the number of queries needed for the page tree's state indicator. This improves responsiveness of the page tree.

It also reduces the number of DB queries when populating the toolbar.

Related resources

Based on an analysis using kolo by @wilhelmklopp and @LilyFoote
...

Checklist

[x] I have opened this pull request against master
[x] I have added or modified the tests when changing logic
[x] I have followed the conventional commits guidelines to add meaningful information into the changelog
[x] I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

fsbraun commented 4 months ago

@marksweb Indeed. I added a test that ensures one query by indicator.