Closed matthiask closed 3 months ago
I pushed this forward for the next person. Here's my message from the last commit:
It instruments the single template render, but not the inherited templates and I'm guessing not the included templates either. I suspect we're going to have to patch jinja templates more robustly than relying on the django jinja backend template class.
@tim-schilling It would be great if we were able to inspect all of Jinja2's rendering but maybe that's harder because of Jinja2's template compilation, or what do you think? I didn't do much research here, so I'm basically just speculating.
I think what we have with your changes is already much better than the status quo. We could merge this, document the limitations and move on?
For what it's worth, this patch on its own would be very useful for my jinja projects. I very rarely use the toolbar to inspect parents/included templates.
@tim-schilling Do you have any reservations against merging this as it is, since it's more useful than the status quo?
No, it is better. I'd prefer to document the caveat better for sure, but if it helps others that's still a win.
@matthiask this is ready for your review. I don't think you'll be able to give it a green checkmark since you opened the PR.
I'm going to assume your previous comments were tacit approval. I'm about to head out for the day and I'd like to get this in for 4.4.4 with #1946
Thank you! I'm late to the party today.
Refs #1881.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. Your commit message should include this information as well.
Fixes # (issue)
Checklist:
docs/changes.rst
.