Closed living180 closed 7 months ago
I think we previously left the selenium tests off because they're a bit burdensome to run locally.
Yes, this PR isn't changing that default, it is just making it possible to enable them through tox if desired. Right now the Contributing docs includes the following snippet:
The first two lines using make
work, but the third using tox
doesn't without this change, since tox won't pass through the DJANGO_SELENIUM_TESTS
variable without it.
Description
When running tox, pass through the user's
DISPLAY
andDJANGO_SELENIUM_TESTS
environment variables, so thatwill actually run the Selenuim integration tests. Without this change, the test suite never sees the
DJANGO_SELENIUM_TESTS
variable and thus skips the integration tests. WithoutDISPLAY
, the integration tests will error out (unlessCI
is present in the environment to instruct the test suite to run the Selenium webdriver in headless mode).Checklist:
docs/changes.rst
.