django-commons / django-debug-toolbar

A configurable set of panels that display various debug information about the current request/response.

https://django-debug-toolbar.readthedocs.io

BSD 3-Clause "New" or "Revised" License

8.08k stars 1.05k forks source link

Limit the cases for E001 to likely scenarios #1925

Closed tim-schilling closed 3 months ago

tim-schilling commented 4 months ago

Description

Only when the user is customizing both the show toolbar callback setting and the URLs aren't installed will the underlying NoReverseMatch error occur.

Fixes #1920

Checklist:

[x] I have added the relevant tests for this change.
[x] I have added an item to the Pending section of docs/changes.rst.

tim-schilling commented 4 months ago

@matthiask I'm pretty confident the advanced installation is only necessary if the show toolbar callback isn't making use of settings.DEBUG.