django-commons / django-debug-toolbar

A configurable set of panels that display various debug information about the current request/response.

https://django-debug-toolbar.readthedocs.io

BSD 3-Clause "New" or "Revised" License

8.08k stars 1.05k forks source link

Remove rem units from svg #1942

Closed michjnich closed 3 months ago

michjnich commented 3 months ago

Description

Removes the "1rem" height and width from the svg attributes for the dark/light icons and puts it into css height and width attributes instead

Fixes #1935

Checklist:

[x] I have added the relevant tests for this change. (Note: No tests added)
[x] I have added an item to the Pending section of docs/changes.rst.

michjnich commented 3 months ago

Quick note: I couldn't run full tests here without setting up a load of databases locally (side note, might be an idea to include a compose file that sets up the various dbs for the full tox run, to make life simpler), and since this was a pure display change I figured that was probably OK :)

tim-schilling commented 3 months ago

Looks good! I'll pull this down, verify it's right then merge.

We don't expect people to run the tests locally against all DBs unless that's what the change is relevant for. Testing against sqlite is sufficient.

tim-schilling commented 3 months ago

Thank you @michjnich!

michjnich commented 3 months ago

And thank you for a pleasant contributor experience :)