django-commons / django-debug-toolbar

A configurable set of panels that display various debug information about the current request/response.
https://django-debug-toolbar.readthedocs.io
BSD 3-Clause "New" or "Revised" License
8.08k stars 1.05k forks source link

Dark mode text needs higher contrast #1943

Closed tim-schilling closed 2 months ago

tim-schilling commented 3 months ago

The table, non-highlighted, text needs greater contrast with the background in dark mode:

It's currently at 1.73 according to https://coolors.co/contrast-checker/acc8e5-ffffff

Screenshot 2024-07-04 at 11 24 22 AM
myou1985 commented 2 months ago

In a Windows11 environment, this was reproduced when the OS mode was "Light" and the app mode was "Dark". Contrast is important, but wouldn't it be better for the app's style to follow the OS mode?

OS mode:Lignt , App mode:Lignt: OSLight-AppLight

OS mode:Light , App mode:Dark: OSLight-AppDark

OS mode:Dark , App mode:Light: OSDark-AppLight

OS mode:Dark , App mode:Dark: OSDark-AppDark

myou1985 commented 2 months ago

I hope that the information at the following URL will be helpful regarding contrast. https://w3c.github.io/wcag/techniques/general/G18

tokibito commented 2 months ago

@tim-schilling I'd be grateful for your feedback on @myou1985's comment. I helped him with his investigation.

tim-schilling commented 2 months ago

@tokibito @myou1985 thank you for bringing up reflecting the OS mode. That'd be a reasonable default.

Do either of you have the availability to make these changes? I'd love to see these changes included in the toolbar.

myou1985 commented 2 months ago

@tim-schilling Thank you for your response. I will find some time to address this issue on my end.

myou1985 commented 2 months ago

@tim-schilling I have submitted my first pull request to this project, and I would really appreciate it if you could take a look when you have the time.

This is my first contribution to an open-source project, so any feedback or suggestions for improvement would be incredibly valuable to me.