Closed matthiask closed 2 months ago
Do you think we should add something to address this concern? I totally agree with you but I have a hard time finding ways to describe this without referring to particular cases.
I don't know. It feels like it's a thing we need to commit to or not. Otherwise we end up with code like this, which I'd argue is adding code to please a configuration.
I think merging this PR is a step forward regardless.
OK let's do it step by step. Thank you!
I think we should an official paragraph to the contributing docs regarding our stance on typing. I tried describing what we're doing currently since I think it makes sense, but I'm definitely open to changing this. I don't think we should open a big round of discussions on this though.