search

django-commons / django-debug-toolbar

A configurable set of panels that display various debug information about the current request/response.
https://django-debug-toolbar.readthedocs.io
BSD 3-Clause "New" or "Revised" License
8.08k stars 1.05k forks source link

Adding in support for Python 3.13 #2014

Closed abeed-avayu closed 1 week ago

abeed-avayu commented 2 weeks ago

Description

This adds support for Python 3.13. I think I've got all the references, but there's probably somewhere else that I've overlooked.

Shout-out to London Django Meetup for the Hacktoberfest Hackathon inspiration. CC @adamchainz et al.

Testing notes

I ran this under docker (python:3.13-slim) locally and make test and make coverage passed all the tests. Would have also tried with a virtualenv but pyenv didn't have 3.13 (non-RC) at the time of testing.

Checklist:

matthiask commented 2 weeks ago

Thanks! The failures are probably due to psycopg2 not having 3.13-compatible wheels yet. (https://github.com/psycopg/psycopg2/pull/1729)

I added some comments.

abeed-avayu commented 1 week ago

I've probably overstepped the mark by removing 3.8 as it's end of life, but as the next version release looks to be a major one I thought it would be compatible with that. Let me know if that's a problem and I'll reinstate it.

matthiask commented 1 week ago

I've probably overstepped the mark by removing 3.8 as it's end of life, but as the next version release looks to be a major one I thought it would be compatible with that. Let me know if that's a problem and I'll reinstate it.

On a pedantic day I'd like this to happen with a separate pull request. Today I'm feeling generous :) I think supporting 5 minor Python versions at the same time is enough and I'm therefore fine with it. CI isn't free energy wise after all.

matthiask commented 1 week ago

Thank you for your contribution!