Task edit view not updating the queues choices

django-commons / django-tasks-scheduler

Schedule async tasks using redis protocol. Redis/ValKey/Dragonfly or any broker using the redis protocol can be used.

https://django-tasks-scheduler.readthedocs.io/

MIT License

58 stars 11 forks source link

Task edit view not updating the queues choices #132

Closed gabriels1234 closed 4 months ago

gabriels1234 commented 5 months ago

Describe the bug Weird behavior where the fix for #119 seemed to have introduced a bug in the edit view of the tasks.

Queues:

admin/scheduler/crontask//change/:

Expected behavior After the fix for #119, the choices are first fixed, and then updated on page load (I guess). Although Initially I think I saw it working, currently I am not able to change the queue.

Desktop (please complete the following information):

python version 3.12
django==5.0.6 (latest stable)
django-tasks-scheduler==1.3.3

Thanks so much!

cunla commented 5 months ago

Hi, sorry for the delayed response.. busy days :) I'll have a look at it this weekend

cunla commented 4 months ago

Hi, I am not able to replicate this error. However, I decided to remove support for older django versions to make this easier to maintain. I release v1.3.4 with up-to-date dependencies. And will publish v2.0.0 with support for django 5 and above where this is no longer an issue (https://docs.djangoproject.com/en/5.0/ref/models/fields/#choices)

gabriels1234 commented 4 months ago

Thanks @cunla ! I would love to keep support for django 4.2 especially since it's in LTS until past 2026. If not, I'd add in the docs that Django 4 projects should pin to 1.3.2 (or try 1.3.3, 1.3.4). Will keep you posted. Thanks again!